Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make JSON2 the now JSON formatting to fix an issue in formatting associative array #10928

Merged
merged 5 commits into from Dec 1, 2016
Merged

Make JSON2 the now JSON formatting to fix an issue in formatting associative array #10928

merged 5 commits into from Dec 1, 2016

Conversation

mattab
Copy link
Member

@mattab mattab commented Dec 1, 2016 •
edited

@mattab mattab added c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. labels Dec 1, 2016
@mattab mattab added this to the 3.0.0-b4 milestone Dec 1, 2016
@tsteur
Copy link
Member

tsteur commented Dec 1, 2016

Once this change is merged we should test piwik mobile with it

@mattab mattab mentioned this pull request Dec 1, 2016
Closed
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Dec 1, 2016
@mattab mattab merged commit 2c39500 into 3.x-dev Dec 1, 2016
@mattab mattab deleted the 8566_json2 branch December 1, 2016 07:56
@mattab mattab mentioned this pull request Dec 1, 2016
Closed
@tsteur
Copy link
Member

tsteur commented Dec 3, 2016

Likely broke #10948

This is probably quite a big breaking change that affect many people and not only SDKs or mobile app

@mattab
Copy link
Member Author

mattab commented Dec 5, 2016

@tsteur Alright, reverting this. It may not be possible to actually change the json format until a new Piwik Mobile would be use json2 or so and available to most android/ios users.

@mattab mattab mentioned this pull request Dec 5, 2016
Merged
mattab added a commit that referenced this pull request Dec 5, 2016
@mattab
Merge pull request #10959 from piwik/revert_json2
cfcefa5 
Don't change json2 format for Piwik 3 (revert #10928)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.0.0-b4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mattab @tsteur